Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improvements in the computation of eclipsing lead to significant improvements of the solar radiation pressure modeling when compared to GMAT:
Note that some of these changes could be due to the improvements in the ephemeris itself by using ANISE in the first place, but I don't think so because I'm pretty sure I had checked that.
Architectural Changes
EclipseState
is goneline_of_sight
andeclipse_state
are both removed in favor of ANISE's implementationNew Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
No additional validation, but rechecking the SRP validation.
Documentation
This PR does not primarily deal with documentation changes.